chore(catalog-generator): Add tests for the Catalog generator #1519
+584
−369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lordrip
force-pushed
the
chore/add-tests-catalog-generator
branch
from
bb0b444 to
66882b8
Compare
At this time, we're adding tests for the `ConfigBean` class and the `GenerateCommandTest` class. fix: KaotoIO#1250
lordrip
force-pushed
the
chore/add-tests-catalog-generator
branch
from
66882b8 to
ccc4435
Compare
igarashitm
approved these changes
Oct 2, 2024
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage ? 69.97%
Complexity ? 62
=======================================
Files ? 276
Lines ? 7726
Branches ? 1514
=======================================
Hits ? 5406
Misses ? 2270
Partials ? 50 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At this time, we're adding tests for the
ConfigBeanclass and theGenerateCommandTestclass.Note
This PR doesn't fulfill the entire issue but is another step towards adding more coverage to the catalog generator.
fix: #1250